Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mysql client commands to connect to remote instances #269

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Allow mysql client commands to connect to remote instances #269

merged 1 commit into from
Feb 13, 2020

Conversation

rayzilt
Copy link
Contributor

@rayzilt rayzilt commented Jan 8, 2020

This PR will change two task commands to allow connecting to remote MySQL instances.

@mamedin
Copy link
Contributor

mamedin commented Feb 12, 2020

Hi @rayzilt,

I think this PR is not needed once #277 and #276 are merged.

archivematica_src_configure_dashboard should be false when deploying a standalone SS.
archivematica_src_configure_ss should be false when deploying a separate pipeline.

@mamedin mamedin self-assigned this Feb 12, 2020
@mamedin
Copy link
Contributor

mamedin commented Feb 13, 2020

Makes sense when MySQL is located in a separate server.

mamedin
mamedin approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@mamedin mamedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mamedin mamedin merged commit b8e4fe9 into artefactual-labs:qa/1.x Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamedin mamedin mamedin approved these changes

Assignees

@mamedin mamedin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayzilt @mamedin