Remove role dependency (geerlingguy.nodejs) #152
Conversation
Remove role dependency and add it to the playbook instead, for the following reasons: - when included as a dependency, the nodejs role is run each time the archivematica-src role is executed, which may not be desired (for example when just doing an upgrade of Archivematica) - by putting explicitly in the playbook, it is more clear what the playboook does and also where to do variable fixes when required
|
Related to #151 |
|
Sorry from which playbook are you installing nodejs now? |
|
Something like artefactual/deploy-pub#50 can be used (it essentially adds a couple of lines in the requirements.yml file to download the nodejs role, and adds another couple of lines in the playbook to run this role before running the archivematica-src role) |
|
Hmm ok I see but for some reason it doesn't feel right, don't you think? Shouldn't that stuff be encapsulated in this role somehow? If adding the requirements to meta doesn't work maybe we can vendor it? Would that be possible? |
|
Hmm, I am starting to understand your point ( initially I was thinking: why only nodejs is included as a role dependency while other roles such as clamav, gearman are in the playbook, now I realize it's a different type of dependency ). However the role dependency in its current state breaks (ref. #151), so we need to fix it somehow. |
|
Closing this (replaced by #153) |
Remove role dependency and add it to the playbook instead, for the
following reasons:
archivematica-src role is executed, which may not be desired (for
example when just doing an upgrade of Archivematica)
playboook does and also where to do variable fixes when required