Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test AM Vagrant box before publishing it #365

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

replaceafill
Copy link
Contributor

While testing #364 locally I noticed that the AM vagrant box build finishes successfully but the AM services do not start due to Python 3.9 missing.

The reason is this block in the clean up process:

# Delete development packages
dpkg --list \
    | awk '{ print $2 }' \
    | grep -- '-dev$' \
    | xargs apt-get -y purge;

That expression is too loose and it matches python3.9-dev among other important libraries for AM.

So, this adds steps to test the Vagrant box created through the Archivematica Vagrant box CI workflow.

In the commits of the pull request you can see how the new test fails in https://github.com/artefactual-labs/am-packbuild/tree/b4c7fb99e81ff20e92c4bcf42a657d569d1206d0 because Python 3.9 has been deleted:

imagen

Then after removing the block from the clean up file above the test passes in https://github.com/artefactual-labs/am-packbuild/tree/32b3184a92f99c37228b64be2509987238e82a14.

I also split the workflow into two jobs, one for building the base image and one for building, testing and publishing the AM box image. This saves time if the AM box build fails but the base image has been created successfully and the workflow needs to be retried.

Connected to archivematica/Issues#1720

This splits the workflow in two jobs, one for building the Ubuntu
20.04 base image and one for building and publishing the AM vagrant
box.
This adds steps to provision a VM using Vagrant and VirtualBox and
tests if AM responds to API endpoint calls.
This runs the workflow to demonstrate that the box is currently broken
because Python 3.9 is deleted in the clean up process.
Copy link
Contributor

@Dhwaniartefact Dhwaniartefact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@replaceafill replaceafill merged commit 28e01ef into qa/1.x Jan 21, 2025
1 check passed
@replaceafill replaceafill deleted the dev/test-am-vagrant-workflow branch January 21, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants