rpm/siegfried: stop using %defattr directive #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #151 - we were not using the `%defattr` directive properly. This commits removes it. It seams reasonable to expect that the user wanting to update the signature file needs root privileges.
|
👍 Current siegfried version is |
scollazo
approved these changes
May 2, 2018
Do I have to make that change against the new qa/1.x? Also I'm realizing this PR should now target stable/1.7.x, am I right? Thanks. |
|
The stable/1.7.x and qa/1.x branches were created after the archivematica 1.7 release, they didn't exist when this PR was created!
|
|
Are you suggesting that we do both? |
|
No, I don't know the scope of this change, and was only enumerating the options. |
|
@sevein 🏓 . Should this be part of 1.7.x? |
|
Done, now it targets stable/1.7.x. I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #151 - we were not using the
%defattrdirective properly. Thiscommits removes it. It seams reasonable to expect that the user wanting to
update the signature file needs root privileges.