Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Fix Temporary Directory Hijacking or Information Disclosure Vulnerability #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[SECURITY] Fix Temporary Directory Hijacking or Information Disclosure Vulnerability #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions wls-common/src/main/java/org/jboss/arquillian/container/wls/ShrinkWrapUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@

import java.io.File;
import java.io.FileOutputStream;
import java.net.URL;
import java.net.URL;
import java.nio.file.Files;

import org.jboss.shrinkwrap.api.Archive;
import org.jboss.shrinkwrap.api.exporter.ExplodedExporter;
Expand All @@ -45,9 +46,7 @@ private ShrinkWrapUtil() {
public static URL toURL(final Archive<?> archive) {
// create a random named temp file, then delete and use it as a directory
try {
File root = File.createTempFile("arquillian", archive.getName());
root.delete();
root.mkdirs();
File root = Files.createTempDirectory("arquillian" + archive.getName()).toFile();

File deployment = new File(root, archive.getName());
deployment.deleteOnExit();
Expand All @@ -61,9 +60,7 @@ public static URL toURL(final Archive<?> archive) {
public static URL toURL(final Descriptor descriptor) {
// create a random named temp file, then delete and use it as a directory
try {
File root = File.createTempFile("arquillian", descriptor.getDescriptorName());
root.delete();
root.mkdirs();
File root = Files.createTempDirectory("arquillian" + descriptor.getDescriptorName()).toFile();

File deployment = new File(root, descriptor.getDescriptorName());
deployment.deleteOnExit();
Expand Down Expand Up @@ -106,9 +103,7 @@ public static File toFile(final Archive<?> archive) {
public static File toFile(final Archive<?> archive, final boolean exploded) {
// create a random named temp file, then delete and use it as a directory
try {
File root = File.createTempFile("arquillian", archive.getName());
root.delete();
root.mkdirs();
File root = Files.createTempDirectory("arquillian" + archive.getName()).toFile();

File deployment = new File(root, archive.getName());
deployment.deleteOnExit();
Expand Down