Refactor triggering #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastanca
reviewed
Jun 16, 2020
| transform.rotation = endRotation; | ||
| transform.position = endPosition; | ||
|
|
||
| OnTurnLeftFinished(); |
There was a problem hiding this comment.
Acá se te van a llamar ambos sea cual sea el sentido en el que rotes. No recuerdo que hacen y creo que no pasa nada pero puede ser una fuente de bugs a futuro (si es que lo tiene)
| @@ -1,261 +0,0 @@ | |||
| using UnityEngine; | |||
There was a problem hiding this comment.
Este file que venia con el modelo era el que manejaba toda la logica de teletransportación, ya la traia resuelta. Para no reinventarlo no podriamos usarlo junto con el behaviour y hacer como un delegate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements which can interact with ARPB2 should now have a child of
ElementBehaviourcomponent attached, overriding the methodInteractWith.Properties of
ElementBehaviourinclude:interact. Teleports are manual.NOTA: No se pq me subió 200 assets 🤷 Si se quiere revisar el código, hacer Ctrl + F, ".cs"