Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RK3588 add HDMI sound, add support for OPi5 Max #7884

Merged
merged 2 commits into from
Feb 27, 2025
Merged

RK3588 add HDMI sound, add support for OPi5 Max #7884

merged 2 commits into from
Feb 27, 2025
+778 −2

Conversation

palachzzz
Copy link
Contributor

@palachzzz palachzzz commented Feb 26, 2025 •
edited
Loading

RK3588 HDMI sound patch by @cazou
https://lore.kernel.org/linux-rockchip/[email protected]/
Added second HDMI port for Orange Pi 5 Max
Added HDMI sound for Orange Pi 5 Max
Added Orange Pi 5 Max edge kernel support

Description

RK3588 is under intensive development in mainline kernel, but some useful patches already there, and could be applied,
HDMI sound is important feature for desktop applications.

Patch includes:

  • HDMI Sound patch for RK3588 by Detlev Casanova (with minor changes to avoid conflict with patch 0113)
  • Second HDMI activation on OPi5 Max
  • Sound activation for HDMI0 and HDMI1 on OPi5 Max
  • Activation of edge kernel for OPi5 Max

Can be extended for other RK3588 boards

Documentation summary for feature / change

HDMI0 and HDMI1 video output hotplug is working, but hotplug for sound seems to not to be working (need reboot in case of change HDMI port)

How Has This Been Tested?

  • Build Ubuntu Noble with mesa-vpu and bcmdhd extensions, 6.14-rc4 kernel.
  • HW test with 4k TV in 4K and FullHD video mode, HDMI0 and HDMI1

Checklist:

  • I have performed a self-review of my own code

RK3588 added HDMI sound patch by Detlev Casanova <detlev.casanova@col…
8a2e18a 
…labora.com>

Added second HDMI port for Orange Pi 5 Max
Added HDMI sound for Orange Pi 5 Max
Added Orange Pi 5 Max edge kernel support
@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Feb 26, 2025
@amazingfate
Copy link
Contributor

rk3588-1xxx patches are for board level changes. For driver and soc dts changes the patch name shoud start with rk3588-0xxx.

@palachzzz
Copy link
Contributor Author

Ok, done

EvilOlaf
EvilOlaf approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@EvilOlaf EvilOlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-test if due to the name changes all patches still apply cleanly and if so lgtm.

@palachzzz
Copy link
Contributor Author

Yes, I tested it before submitting name changes

@amazingfate amazingfate merged commit 0b88561 into armbian:main Feb 27, 2025
10 checks passed
Grippy98 pushed a commit to Grippy98/build that referenced this pull request Feb 28, 2025
@palachzzz @Grippy98
RK3588 add HDMI sound, add support for OPi5 Max armbian#7884
5563cee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvilOlaf EvilOlaf EvilOlaf approved these changes

@amazingfate amazingfate amazingfate approved these changes

@ColorfulRhino ColorfulRhino Awaiting requested review from ColorfulRhino ColorfulRhino is a code owner

@JohnTheCoolingFan JohnTheCoolingFan Awaiting requested review from JohnTheCoolingFan JohnTheCoolingFan is a code owner

@Manouchehri Manouchehri Awaiting requested review from Manouchehri Manouchehri is a code owner

@SuperKali SuperKali Awaiting requested review from SuperKali SuperKali is a code owner

@TRSx80 TRSx80 Awaiting requested review from TRSx80 TRSx80 is a code owner

@TheSnowfield TheSnowfield Awaiting requested review from TheSnowfield TheSnowfield is a code owner

@Tonymac32 Tonymac32 Awaiting requested review from Tonymac32 Tonymac32 is a code owner

@ahoneybun ahoneybun Awaiting requested review from ahoneybun ahoneybun is a code owner

@brentr brentr Awaiting requested review from brentr brentr is a code owner

@catalinii catalinii Awaiting requested review from catalinii catalinii is a code owner

@clee clee Awaiting requested review from clee clee is a code owner

@efectn efectn Awaiting requested review from efectn efectn is a code owner

@igorpecovnik igorpecovnik Awaiting requested review from igorpecovnik igorpecovnik is a code owner

@joekhoobyar joekhoobyar Awaiting requested review from joekhoobyar joekhoobyar is a code owner

@krachlatte krachlatte Awaiting requested review from krachlatte krachlatte is a code owner

@lanefu lanefu Awaiting requested review from lanefu lanefu is a code owner

@paolosabatino paolosabatino Awaiting requested review from paolosabatino paolosabatino is a code owner

@rpardini rpardini Awaiting requested review from rpardini rpardini is a code owner

@schwar3kat schwar3kat Awaiting requested review from schwar3kat schwar3kat is a code owner

Assignees
No one assigned
Labels
Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palachzzz @amazingfate @EvilOlaf