Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockchip64-6.6/6.12/6.13: rk3308b: add vop and internal rgb lcdc output #7866

Merged
merged 5 commits into from
Feb 23, 2025

Conversation

TheSnowfield
Copy link
Collaborator

@TheSnowfield TheSnowfield commented Feb 22, 2025

Description

  • add rk3308 vop registers and probe match string rockchip,rk3308-vop
  • dtsi: add lcdc pinctrl definitions
  • dtsi: add display system
  • enable lcdc pinmux after initializing rgb, see rockchip_rgb.c
  • use full blobs to boot for sakurapi-rk3308b

How Has This Been Tested?

./compile.sh BOARD=sakurapi-rk3308b BRANCH=current KERNEL_BTF=yes

everything works okay.

  • rk3308 vop & internal rgb output

image

@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Feb 22, 2025
@TheSnowfield TheSnowfield requested a review from chainsx February 22, 2025 10:52
@chainsx chainsx added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Feb 22, 2025
@github-actions github-actions bot added Needs review Seeking for review and removed Ready to merge Reviewed, tested and ready for merge labels Feb 22, 2025
@chainsx chainsx added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Feb 22, 2025
@paolosabatino
Copy link
Contributor

Looks fine to me, except for the fact that the patch has been introduced for rockchip64 kernel 6.6 and 6.12, but the current kernel is 6.12 and edge is 6.13; @TheSnowfield you should introduce the patches for edge 6.13 too, or probably they will miss the forthcoming bump of edge to 6.14

Copy link
Contributor

@ssp97 ssp97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works.
image

@github-actions github-actions bot added Needs review Seeking for review and removed Ready to merge Reviewed, tested and ready for merge labels Feb 22, 2025
@TheSnowfield
Copy link
Collaborator Author

Looks fine to me, except for the fact that the patch has been introduced for rockchip64 kernel 6.6 and 6.12, but the current kernel is 6.12 and edge is 6.13; @TheSnowfield you should introduce the patches for edge 6.13 too, or probably they will miss the forthcoming bump of edge to 6.14

Thanks for your advice, I've done my work :)

@TheSnowfield TheSnowfield changed the title rockchip64-6.6/6.12: rk3308b: add vop and internal rgb lcdc output rockchip64-6.6/6.12/6.13: rk3308b: add vop and internal rgb lcdc output Feb 22, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release and removed Needs review Seeking for review labels Feb 22, 2025
@igorpecovnik igorpecovnik merged commit bc69b1d into armbian:main Feb 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

5 participants