Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use deb822 APT source for armbian-config #7782

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

blieque
Copy link
Contributor

@blieque blieque commented Feb 3, 2025

Replace creation of armbian-config.list with armbian-config.sources. This holds the same information in a newer format, deb822. APT has supported this format since version 1.1, released in 2015.

This does not affect armbian.list.

See also:

How Has This Been Tested?

None

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@blieque blieque requested review from a team and igorpecovnik as code owners February 3, 2025 22:09
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Feb 3, 2025
- Replace creation of `armbian-config.list` with
  `armbian-config.sources`. This holds the same information in a newer
  format, deb822. This does not affect `armbian.list`.

See also: armbian/configng#407
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release labels Feb 4, 2025
@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik merged commit 3743daf into armbian:main Feb 4, 2025
11 checks passed
@igorpecovnik
Copy link
Member

Something ain't right.

schwar3kat:tchncs.de My local armbian build compiles are failing near the end like this:
Command failed, retrying in 5s [ chroot_sdcard_apt_get_update ]
E: Invalid value set for option Signed-By regarding source https://github.armbian.com/configng/ stable (not a fingerprint)
E: The list of sources could not be read.
Command failed, retrying in 5s [ chroot_sdcard_apt_get_update ]
Command failed 3 times, giving up [ chroot_sdcard_apt_get_update ]

@igorpecovnik
Copy link
Member

Double quotes are problem ... fix coming up asap.

@blieque blieque mentioned this pull request Feb 7, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Framework Framework components Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants