Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sunxi 6.12: Switch to v6.12.16, Add HDMI support #7752

Merged
merged 12 commits into from
Feb 26, 2025
Merged

sunxi 6.12: Switch to v6.12.16, Add HDMI support #7752

merged 12 commits into from
Feb 26, 2025

Conversation

The-going
Copy link
Contributor

@The-going The-going commented Jan 26, 2025 •
edited
Loading

Description

  • Switch to v6.12.16
  • sun50i-h616 & overlays: sort nodes, add overlays.
  • Add drm sun4i-de33 driver.
  • arm64: dts: Add axp313a.dtsi
  • add sun50i-h616-hdmi-phy support
  • tcon (timing controller), enable HDMI for H616/H618 SOC
  • Add GPU power domain for h616
  • Add sun50i-h618-bananapi-m4-berry support

How Has This Been Tested?

  • Test build kernel
  • Test work HDMI output on boards: BPI-M64, BPI-M4-Berry
  • Test build minimal image for BPI-M4-Berry

@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jan 26, 2025
@pyavitz
Copy link
Collaborator

pyavitz commented Jan 26, 2025

I haven't been able to get the M4 Zero to boot above v2024.04 in Armbian for some reason. I figured it was something in the Kernel patching as I am able to do so in my personal builds.

Does this PR have eMMC boot support?

@The-going
Copy link
Contributor Author

The-going commented Jan 27, 2025 •
edited
Loading

I haven't been able to get the M4 Zero to boot above v2024.04 in Armbian for some reason.

u-boot v2025.01 in the default configuration for h616, implies OF_UPSTREAM to be set to y.
And CONFIG_DEFAULT_DEVICE_TREE="allwinner/sun50i-h618-bananapi-m4-berry".
Therefore, the dts must be placed in the dts/upstream/...... path.

Does this PR have eMMC boot support?

eMMC is detected correctly. I haven't tried downloading from eMMC yet.

Detected problems:
The Ethernet is not working.
The HDMI is not working.

Strange. The same changes on core 6.6, the HDMI works for me,
but the temperature sensor shows a lot and the board turns off.

@The-going
Copy link
Contributor Author

M4 Zero

Is the Ethernet working?

@pyavitz
Copy link
Collaborator

pyavitz commented Jan 27, 2025

M4 Zero

Is the Ethernet working?

It uses emac1, which at this time requires some special driver and although some one recently added it to Armbian I haven't tried testing it. Doesn't even have an eth port anyway, which I'm guessing means there is a HAT you can use on it.

As for the u-boot, yes I've done all that. The issue for me, is that above U-Boot v2024.04 it won't load the Armbian kernel. It just hangs at the loading stage. If I use my own kernel, it loads fine. Not sure why, just like I haven't been able to figure out why the Bluetooth fails to load in Armbian either.

@The-going
Copy link
Contributor Author

As for the u-boot, yes I've done all that. The issue for me, is that above U-Boot v2024.04 it won't load the Armbian kernel

I suspect that this is with the 6.6 kernel.
At the boot stage, as soon as the temperature driver is connected and starts working,
it reads a very large temperature value and shuts down the OS.

@pyavitz
Copy link
Collaborator

pyavitz commented Jan 27, 2025

Maybe some of these patches will help?

@igorpecovnik
Copy link
Member

You decide when this is ready. Also we need to move CURRENT to 6.12, legacy 6.6, edge 6.13 by the end of 2/2025. Any deep problems preventing this?

@The-going
Copy link
Contributor Author

You decide when this is ready. Also we need to move CURRENT to 6.12, legacy 6.6, edge 6.13 by the end of 2/2025. Any deep problems preventing this?

We can reschedule it at any time.
I would like to do this soon.
But I think it's better to fix it first:

  • The 6.6 core works well, except for the temperature sensors for h6-h618, and temperature control is not possible for them.

  • In the 6.12 kernel, for some reason, HDMI does not work for arm64.

  • There are several patches in the 6.12 kernel that add drivers from legacy kernels.
    It seems to me that there are problems there.

  • In the 6.13 kernel, which all the patches have moved to, I have already started making some changes.
    But they need to be tested. Therefore, I am first adding support for a device with an h618 processor.

What should I do first?
Probably something that will turn out faster.
I will inform you additionally when it will be possible to safely combine pull requests.

@igorpecovnik
Copy link
Member

What should I do first?

Kernel 6.12 should be main priority, 6.13 slow.

@The-going
Copy link
Contributor Author

The-going commented Jan 30, 2025 •
edited
Loading

It's been a long time since I've read so much primary documentation.
I saw some inconsistency with the user manual of the h616 processor.
This applies to syscon and ethernet nodes.

@TheSnowfield @chraac @JohnTheCoolingFan
Please tell me, does Ethernet work for your devices on this 6.12 kernel?
No changes to this pull request.

@JohnTheCoolingFan
Copy link
Contributor

Please tell me, does Ethernet work for your devices on this 6.12 kernel?

Tried this branch on bigtreetech cb1, ethernet works as usual.

@Jan-cpu82
Copy link 

* In the 6.12 kernel, for some reason, HDMI does not work for arm64.

It looks like after sunxi-6.7 the "drivers-hack-for-h616-hdmi-video-output.patch" and several
drv-media-cedrus-... patches were deleted in commit 5838fac as "unused"
As h616/618 hdmi support is still not in mainline this is stil needed in my opinion.
The easiest solution is probably to take the latest mainlining effort patchset for 6.12:
https://patchwork.kernel.org/project/dri-devel/cover/[email protected]/#26045134

@The-going
Copy link
Contributor Author

The-going commented Feb 9, 2025 •
edited
Loading

Added the DE33 driver.
At this stage, the compilation is error-free.
The core runs on the h618 platform.
For proper operation, it seems necessary to add compatibility with

allwinner,sun50i-h616-de33
allwinner,sun50i-h616-de33-clk
allwinner,sun50i-h616-de33-mixer-0

@TheSnowfield
Copy link
Collaborator

It's been a long time since I've read so much primary documentation. I saw some inconsistency with the user manual of the h616 processor. This applies to syscon and ethernet nodes.

@TheSnowfield @chraac @JohnTheCoolingFan Please tell me, does Ethernet work for your devices on this 6.12 kernel? No changes to this pull request.

Sorry, I can't test my sakurapi-3308b, because it was a broken boot on the latest Armbian. I haven't figured out the problem.

@The-going
Copy link
Contributor Author

Sorry, I can't test my sakurapi-3308b

I'm sorry. I thought your interest was sunxi. But your devices are on rockchip chips.

@TheSnowfield
Copy link
Collaborator

Sorry, I can't test my sakurapi-3308b

I'm sorry. I thought your interest was sunxi. But your devices are on rockchip chips.

Haha, never mind. sunxi chip devices will come later :)

@The-going The-going changed the title sunxi 6.12: Switch to v6.12.11, Add BananaPi M4 Berry support sunxi 6.12: Switch to v6.12.13, Add HDMI support Feb 10, 2025
@The-going
Copy link
Contributor Author

DMESG:

bananapim4berry:~$ dmesg | grep -iE 'drm|hdmi|gpu'
[    0.098994] /soc/hdmi@6000000: Fixed dependency cycle(s) with /soc/tcon-top@6510000
[    0.099054] /soc/tcon-top@6510000: Fixed dependency cycle(s) with /soc/hdmi@6000000
[    0.103915] /soc/hdmi@6000000: Fixed dependency cycle(s) with /soc/tcon-top@6510000
[    0.104280] /soc/hdmi@6000000: Fixed dependency cycle(s) with /soc/tcon-top@6510000
[    0.104438] /soc/tcon-top@6510000: Fixed dependency cycle(s) with /soc/hdmi@6000000
[    0.106983] /soc/hdmi@6000000: Fixed dependency cycle(s) with /connector
[    0.107066] /connector: Fixed dependency cycle(s) with /soc/hdmi@6000000
[    1.597542] sun4i-drm display-engine: bound 1100000.mixer (ops 0xffff80008119ac98)
[    1.604970] sun4i-drm display-engine: bound 6510000.tcon-top (ops 0xffff80008119fa38)
[    1.610933] sun4i-drm display-engine: bound 6515000.lcd-controller (ops 0xffff800081197a60)
[    1.613434] sun8i-dw-hdmi 6000000.hdmi: Detected HDMI TX controller v2.12a with HDCP (DWC HDMI 2.0 TX PHY)
[    1.621580] sun8i-dw-hdmi 6000000.hdmi: EVENT=plugin
[    1.622717] sun8i-dw-hdmi 6000000.hdmi: registered DesignWare HDMI I2C bus driver
[    3.483673] sun4i-drm display-engine: bound 6000000.hdmi (ops 0xffff800081199d60)
[    3.491742] [drm] Initialized sun4i-drm 1.0.0 for display-engine on minor 0
[    3.498754] sun8i-dw-hdmi 6000000.hdmi: read_hpd result: 1
[    4.107497] sun4i-drm display-engine: [drm] fb0: sun4i-drmdrmfb frame buffer device
[    8.567030] systemd[1]: Starting [email protected] - Load Kernel Module drm...
[    9.102893] systemd[1]: [email protected]: Deactivated successfully.
[    9.115476] systemd[1]: Finished [email protected] - Load Kernel Module drm.
[   40.468588] sun8i-dw-hdmi 6000000.hdmi: EVENT=plugin
[   41.362152] sun8i-dw-hdmi 6000000.hdmi: EVENT=plugin

At this stage, HDMI works on two boards.
For the h618, the monitor resolution does not switch to the actual available one.
But it's already working.

@igorpecovnik I think it can be taken if someone approves it.

@The-going
Copy link
Contributor Author

Please excuse me.
I will add the bananapi-m4-berry board first to the 6.6 core.

igorpecovnik
igorpecovnik approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge at will

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Feb 26, 2025
@The-going
Copy link
Contributor Author

The-going commented Feb 26, 2025 •
edited
Loading

merge at will

merge

@github-actions github-actions bot added Needs review Seeking for review and removed Ready to merge Reviewed, tested and ready for merge labels Feb 26, 2025
@The-going The-going changed the title sunxi 6.12: Switch to v6.12.13, Add HDMI support sunxi 6.12: Switch to v6.12.16, Add HDMI support Feb 26, 2025
The-going and others added 11 commits February 26, 2025 20:01
@igorpecovnik igorpecovnik merged commit 96e1ca9 into armbian:main Feb 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

@AGM1968 AGM1968 Awaiting requested review from AGM1968 AGM1968 is a code owner

@JohnTheCoolingFan JohnTheCoolingFan Awaiting requested review from JohnTheCoolingFan JohnTheCoolingFan is a code owner

@NicoD-SBC NicoD-SBC Awaiting requested review from NicoD-SBC NicoD-SBC is a code owner

@PanderMusubi PanderMusubi Awaiting requested review from PanderMusubi PanderMusubi is a code owner

@TheSnowfield TheSnowfield Awaiting requested review from TheSnowfield TheSnowfield is a code owner

@Tonymac32 Tonymac32 Awaiting requested review from Tonymac32 Tonymac32 is a code owner

@janprunk janprunk Awaiting requested review from janprunk janprunk is a code owner

@krachlatte krachlatte Awaiting requested review from krachlatte krachlatte is a code owner

@pyavitz pyavitz Awaiting requested review from pyavitz pyavitz is a code owner

@schwar3kat schwar3kat Awaiting requested review from schwar3kat schwar3kat is a code owner

@sgjava sgjava Awaiting requested review from sgjava sgjava is a code owner

@teknoid teknoid Awaiting requested review from teknoid teknoid is a code owner

Assignees
No one assigned
Labels
02 Milestone: First quarter release 05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@The-going @pyavitz @igorpecovnik @JohnTheCoolingFan @Jan-cpu82 @chraac @TheSnowfield @stephengraf