Added PersistableBundle extensions #174
Conversation
WalkthroughThe recent changes introduce an upgrade to the Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant PersistableBundle
participant SerializationLibrary
App->>PersistableBundle: putSerializable(key, value)
PersistableBundle->>SerializationLibrary: serialize(value)
SerializationLibrary-->>PersistableBundle: serializedValue
PersistableBundle-->>App: success
App->>PersistableBundle: getSerializable(key)
PersistableBundle-->>SerializationLibrary: deserialize(serializedValue)
SerializationLibrary-->>PersistableBundle: originalValue
PersistableBundle-->>App: originalValue
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- deps.versions.toml (1 hunks)
- state-keeper/api/android/state-keeper.api (1 hunks)
- state-keeper/src/androidMain/kotlin/com/arkivanov/essenty/statekeeper/PersistableBundleExt.kt (1 hunks)
- state-keeper/src/androidUnitTest/kotlin/com/arkivanov/essenty/statekeeper/AndroidStateKeeperTest.kt (3 hunks)
- state-keeper/src/androidUnitTest/kotlin/com/arkivanov/essenty/statekeeper/BundleExtTest.kt (2 hunks)
- state-keeper/src/androidUnitTest/kotlin/com/arkivanov/essenty/statekeeper/PersistableBundleExtTest.kt (1 hunks)
- state-keeper/src/androidUnitTest/kotlin/com/arkivanov/essenty/statekeeper/TestUtils.android.kt (1 hunks)
Additional comments not posted (24)
state-keeper/src/androidUnitTest/kotlin/com/arkivanov/essenty/statekeeper/TestUtils.android.kt (4)
13-19: LGTM!The function correctly deserializes a
ByteArrayinto aBundleand ensures that the result is non-null.
21-25: LGTM!The function correctly serializes a
PersistableBundleinto aByteArray.
27-33: LGTM!The function correctly deserializes a
ByteArrayinto aPersistableBundleand ensures that the result is non-null.
7-11: LGTM!The function correctly serializes a
Bundleinto aByteArray.state-keeper/src/androidUnitTest/kotlin/com/arkivanov/essenty/statekeeper/BundleExtTest.kt (3)
Line range hint
12-19:
LGTM!The test correctly verifies that a
Serializableobject is correctly retrieved from aBundlewithout serialization.
Line range hint
23-30:
LGTM!The test correctly verifies that a
Serializableobject is correctly retrieved from aBundleafter serialization and deserialization.
Line range hint
33-43:
LGTM!The test correctly verifies that a
Serializableobject is correctly retrieved from aBundleafter double serialization and deserialization.state-keeper/src/androidUnitTest/kotlin/com/arkivanov/essenty/statekeeper/PersistableBundleExtTest.kt (4)
13-21: LGTM!The test correctly verifies that a
Serializableobject is correctly retrieved from aPersistableBundlewithout serialization.
23-31: LGTM!The test correctly verifies that a
Serializableobject is correctly retrieved from aPersistableBundleafter serialization and deserialization.
33-44: LGTM!The test correctly verifies that a
Serializableobject is correctly retrieved from aPersistableBundleafter double serialization and deserialization.
46-47: LGTM!The data class is correctly defined and used in the tests.
state-keeper/src/androidMain/kotlin/com/arkivanov/essenty/statekeeper/PersistableBundleExt.kt (4)
17-20: LGTM!The
putSerializablefunction correctly inserts a serializable value into aPersistableBundleusing the providedSerializationStrategy.
27-29: LGTM!The
getSerializablefunction correctly retrieves a serializable value from aPersistableBundleusing the providedDeserializationStrategy.
35-38: LGTM!The
putSerializableContainerfunction correctly inserts aSerializableContainerinto aPersistableBundleusing theSerializableContainer.serializer().
45-47: LGTM!The
getSerializableContainerfunction correctly retrieves aSerializableContainerfrom aPersistableBundleusing theSerializableContainer.serializer().deps.versions.toml (1)
14-14: Upgrade approved! Verify compatibility.The
robolectricversion has been updated from4.9.1to4.13. Ensure compatibility with the rest of the codebase.state-keeper/src/androidUnitTest/kotlin/com/arkivanov/essenty/statekeeper/AndroidStateKeeperTest.kt (4)
Line range hint
13-27:
LGTM!The
saves_and_restores_state_without_parcellingtest function correctly verifies state saving and restoring without parcelling.
47-47: LGTM!The
saves_and_restores_state_with_parcellingtest function correctly verifies state saving and restoring with parcelling. The change todeparcelizeBundle()improves clarity and specificity.
Line range hint
49-61:
LGTM!The
GIVEN_isSavingAllowed_is_false_on_save_THEN_state_not_savedtest function correctly verifies that state is not saved when saving is not allowed.
75-75: LGTM!The
GIVEN_discardSavedState_is_true_on_restore_THEN_discards_saved_statetest function correctly verifies that saved state is discarded whendiscardSavedStateis true. The change todeparcelizeBundle()improves clarity and specificity.state-keeper/api/android/state-keeper.api (4)
18-19: Ensure proper error handling ingetSerializable.The method
getSerializableretrieves a serializable object from aPersistableBundle. Ensure that the method handles cases where the key does not exist or the deserialization fails.
20-20: Ensure proper error handling ingetSerializableContainer.The method
getSerializableContainerretrieves aSerializableContainerfrom aPersistableBundle. Ensure that the method handles cases where the key does not exist.
21-21: Ensure proper error handling inputSerializable.The method
putSerializableinserts a serializable object into aPersistableBundle. Ensure that the method handles cases where the serialization fails.
22-22: Ensure proper error handling inputSerializableContainer.The method
putSerializableContainerinserts aSerializableContainerinto aPersistableBundle. Ensure that the method handles cases where the container is null or invalid.
arkivanov
force-pushed
the
persistable-bundle-extensions
branch
from
c673f69 to
195b1fe
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- state-keeper/api/android/state-keeper.api (1 hunks)
- state-keeper/src/androidMain/kotlin/com/arkivanov/essenty/statekeeper/PersistableBundleExt.kt (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- state-keeper/api/android/state-keeper.api
- state-keeper/src/androidMain/kotlin/com/arkivanov/essenty/statekeeper/PersistableBundleExt.kt
Summary by CodeRabbit
New Features
PersistableBundle, enhancing state management in Android applications.Bug Fixes
robolectriclibrary, which may include various bug fixes and performance improvements.Tests
PersistableBundleto ensure accurate serialization and deserialization across multiple scenarios.