Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out the Globals global from util/util.go #175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vishal4071
Copy link
Contributor

@vishal4071 vishal4071 commented Feb 19, 2025

Global variables make it harder to track where and how a variable is being modified.
Refactoring becomes difficult as dependencies are scattered across the code.
Since global variables can be accessed and modified from anywhere, changes in one part of the code can unintentionally affect another part.

Removed global from util/util.go

Fixes: BUG1064013

@manith-arista
Copy link
Contributor

We might need to have a syncup with Maciej again, this change might conflict with
#152

@mkisielewski-arista
Copy link
Contributor

We might need to have a syncup with Maciej again, this change might conflict with #152

Indeed, some of the changes here are covered by #152

This PR here has one big commit, but maybe @vishal4071 has this split into separate commits, so it's easier to apply it partially?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants