forked from rmohr/bazeldnf
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add priority option for repo configuration #5
Closed
Closed
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
85bebc4
Add priority option for repo configuration
kellyma2 8ab2cc8
Remove erroneous blank line
kellyma2 f2b3f04
Seperate RepoReducer from CacheHelper implementation
kellyma2 a50651f
Remove unused `lang` option for reducer
kellyma2 e505566
Extract Resolve() function for reducer
kellyma2 c84e3ac
reducer: pull out loadRepos() from Load()
kellyma2 710f6b0
reducer: Decouple loadRepos() from RepoReducer
kellyma2 29bd632
Merge pull request #79 from kellyma2/dead-code
kellyma2 325d64d
reducer: Factor our separate loader
kellyma2 11c8b10
deps: bumps all golang deps
manuelnaranjo 4bbf4e5
Merge pull request #87 from rmohr/mnaranjo/bump-go-dependencies
manuelnaranjo c6d1b89
Make use of cmp.Or instead of complex ifs
manuelnaranjo 60973b1
Using slices.[Sort,SortFunc]
manuelnaranjo 73ea213
test: validate if sorting helps
manuelnaranjo e9f6570
sat: sort inputs to the sat solver for determinism
manuelnaranjo b5efd4c
Merge pull request #86 from rmohr/mnaranjo/make-sat-reproducible
manuelnaranjo b9918d5
Refine loader interface
kellyma2 3d25093
Merge branch 'main' into HEAD
kellyma2 3225b58
Merge pull request #85 from kellyma2/reducer-refactor
kellyma2 3377617
reducer: Add test for loader
kellyma2 816d264
reducer: Add tests for reducer process
kellyma2 891c572
Merge branch 'reducer-test' into priority
kellyma2 f00f2bd
Fix broken behaviour and add some tests
kellyma2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this
RepoReducer.Resolve
unit deserves a unit test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree in practice, if we want to add unit tests for this I think we should handle this separately as the change here is (relatively) narrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without a test, it's arguably incomplete. Is the problem that it's hard to add a test to cover this new logic? It doesn't have to cover everything that was here already.