CI(cv_deploy): Enhance logic and readability of cv_deploy molecule scenario

[alexeygorbunov]

Change Summary

Enhance logic and readability of cv_deploy molecule scenario

Related Issue(s)

Component(s) name

arista.avd.cv_deploy

Proposed changes

• Enhance naming convention of different playbook and CV elements

Examples of the new WS names:

avd-cv-deploy_global-scenario-cleanup_n4w7_cleanup
avd-cv-deploy_force-ws-true_run-cc-false_qqul_cleanup
avd-cv-deploy_force-ws-true_run-cc-false_qqul_converge

• Introduce tagging to control execution of specific tests
• Change approach of assigning cv_deploy - related variables

How to test

Run cv_deploy scenario in CI

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5034
# Activate the virtual environment
source test-avd-pr-5034/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/alexeygorbunov/avd.git@cv_deploy_ci_molecule_enhancement#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/alexeygorbunov/avd.git#/ansible_collections/arista/avd/,cv_deploy_ci_molecule_enhancement --force
# Optional: Install AVD examples
cd test-avd-pr-5034
ansible-playbook arista.avd.install_examples

[ClausHolbechArista]

Minor question on r but I am fine either way.

[ClausHolbechArista]

wouldn't it be best to set this as a play var all the way at the top? So we have a single ID per execution.

[alexeygorbunov]

Agree! Before this unique r was the only way to distinguish results of the different tests. Now all tests have unique names and having them share the same execution ID makes more sense.
I tried to implement it natively with molecule but faced issues here and there. Ended up implementing via externally-fed env which will be generated as a part of the CI pipeline.

New naming convention example (from last manual run):

avd_cv-deploy_scenario-cleanup_tg1b_cleanup
avd_cv-deploy_force-ws-true_run-cc-false_tg1b_cleanup
avd_cv-deploy_force-ws-true_run-cc-false_tg1b_converge
avd_cv-deploy_inactive-device_force-ws-false_tg1b_cleanup
avd_cv-deploy_inactive-device_force-ws-false_tg1b_converge
avd_cv-deploy_inactive-device_force-ws-true_tg1b_cleanup
avd_cv-deploy_inactive-device_force-ws-true_tg1b_converge
avd-cv-deploy_submit-ws-false_tg1b_cleanup
avd-cv-deploy_submit-ws-false_tg1b_converge
avd_cv-deploy_force-ws-true_run-cc-true_tg1b_cleanup
avd_cv-deploy_force-ws-true_run-cc-true_tg1b_converge

Same consistency is implemented in other scenarios that rely on cv_deploy

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud