Refactor(eos_designs): Refactor eos_designs structured_config code for ip_igmp_snooping.py #5012
Conversation
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5012
# Activate the virtual environment
source test-avd-pr-5012/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/designs/ip-igmp-snooping#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/designs/ip-igmp-snooping --force
# Optional: Install AVD examples
cd test-avd-pr-5012
ansible-playbook arista.avd.install_examples |
laxmikantchintakindi
force-pushed
the
refactor/designs/ip-igmp-snooping
branch
3 times, most recently
from
d6672c4 to
471ab10
Compare
github-actions
bot
added
the
state: CI Updated
…r ip_igmp_snooping.py
for more information, see https://pre-commit.ci
laxmikantchintakindi
force-pushed
the
refactor/designs/ip-igmp-snooping
branch
from
de29b9e to
6d6ea64
Compare
|
| if not igmp_snooping_enabled: | ||
| return ip_igmp_snooping | ||
| self.structured_config.ip_igmp_snooping.globally_enabled = igmp_snooping_enabled |
There was a problem hiding this comment.
Move out this line from if code so you dont need to write it again.
There was a problem hiding this comment.
and there is no case of igmp_snooping_enabled: false in molecule so can you recheck that it return None or globally_enabled: false
There was a problem hiding this comment.
Can we add this coverage part in any other PR. In first part we need to add globally_enabled: false only when igmp_snooping_enabled is false and return. If I move out of if condition code will return even when igmp_snooping_enabled is true.
There was a problem hiding this comment.
Can you please check the false case locally to make sure it works fine
| return {"id": vlan.id, **ip_igmp_snooping_vlan} | ||
|
|
||
| return ip_igmp_snooping_vlan | ||
| if strip_empties_from_dict(vlan_item._as_dict()): |
There was a problem hiding this comment.
Need to check if we can avoid to use this method. Will check and update
python-avd/pyavd/_eos_designs/structured_config/network_services/ip_igmp_snooping.py
Show resolved
Hide resolved
Change Summary
Refactor eos_designs structured_config code for ip_igmp_snooping.py.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Refactor eos_designs structured_config code for ip_igmp_snooping.py.
How to test
Checklist
User Checklist
Repository Checklist