-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_designs): ptp_settings.domain #5007
Merged
ClausHolbechArista
merged 4 commits into
aristanetworks:devel
from
ClausHolbechArista:fix/eos_designs/ptp-settings-domain
Feb 11, 2025
Merged
Fix(eos_designs): ptp_settings.domain #5007
ClausHolbechArista
merged 4 commits into
aristanetworks:devel
from
ClausHolbechArista:fix/eos_designs/ptp-settings-domain
Feb 11, 2025
+36
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5007
# Activate the virtual environment
source test-avd-pr-5007/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/eos_designs/ptp-settings-domain#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/eos_designs/ptp-settings-domain --force
# Optional: Install AVD examples
cd test-avd-pr-5007
ansible-playbook arista.avd.install_examples |
danieltudares
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with affected customer repo and this fixes the issue. LGTM!
ansible_collections/arista/avd/roles/eos_designs/docs/tables/node-type-ptp-configuration.md
Show resolved
Hide resolved
|
gmuloc
approved these changes
Feb 11, 2025
ClausHolbechArista
added a commit
to ClausHolbechArista/avd
that referenced
this pull request
Feb 12, 2025
carlbuchmann
pushed a commit
that referenced
this pull request
Feb 12, 2025
joelbreton2
pushed a commit
to joelbreton2/avd
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Fix(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix(eos_designs): ptp_settings.domain
Related Issue(s)
Bug introduced in 5.2, where we no longer honored the setting of
domain
underptp_settings
. Cause by default value in schema for the more specific node setting.Component(s) name
arista.avd.eos_designs
Proposed changes
How to test
Added molecule coverage
Checklist
User Checklist
Repository Checklist