Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): ptp_settings.domain #5007

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Fix(eos_designs): ptp_settings.domain

Related Issue(s)

Bug introduced in 5.2, where we no longer honored the setting of domain under ptp_settings. Cause by default value in schema for the more specific node setting.

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Adjust schema
  • Add test

How to test

Added molecule coverage

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners February 10, 2025 20:54
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5007
# Activate the virtual environment
source test-avd-pr-5007/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/eos_designs/ptp-settings-domain#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/eos_designs/ptp-settings-domain --force
# Optional: Install AVD examples
cd test-avd-pr-5007
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 10, 2025
@ClausHolbechArista ClausHolbechArista added the type: bug Something isn't working label Feb 10, 2025
Copy link
Contributor

@danieltudares danieltudares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with affected customer repo and this fixes the issue. LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 03ef6bb into aristanetworks:devel Feb 11, 2025
44 checks passed
@ClausHolbechArista ClausHolbechArista added this to the v.5.2.1 milestone Feb 12, 2025
ClausHolbechArista added a commit to ClausHolbechArista/avd that referenced this pull request Feb 12, 2025
joelbreton2 pushed a commit to joelbreton2/avd that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants