Refactor(eos_designs): Network Services ethernet interfaces refactoring to classes #4976
+396
−295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4976
# Activate the virtual environment
source test-avd-pr-4976/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@refactor/eos_designs/network-services/ethernet-interfaces#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/network-services/ethernet-interfaces --force
# Optional: Install AVD examples
cd test-avd-pr-4976
ansible-playbook arista.avd.install_examples |
for more information, see https://pre-commit.ci
github-actions
bot
added
the
state: CI Updated
gmuloc
force-pushed
the
refactor/eos_designs/network-services/ethernet-interfaces
branch
from
9559aa3 to
e87f9e0
Compare
gmuloc
force-pushed
the
refactor/eos_designs/network-services/ethernet-interfaces
branch
from
300ec05 to
06e453c
Compare
ClausHolbechArista
requested changes
Feb 6, 2025
...s_negative_unit_tests/inventory/host_vars/duplicate-interfaces-point-to-point-services-1.yml
Show resolved
Hide resolved
...s_negative_unit_tests/inventory/host_vars/duplicate-interfaces-point-to-point-services-4.yml
Show resolved
Hide resolved
| @@ -421,6 +421,10 @@ def _compare(self, other: Self, ignore_fields: tuple[str, ...] = ()) -> bool: | |||
| # Ignore empty lists or classes since they could have been initialized in the code but they would be trimmed from the output. | |||
| continue | |||
|
|
|||
| if (value and not other_value) or (not value and other_value): | |||
There was a problem hiding this comment.
Let's get the refactored stuff in the BGP pr in quick so this will not be needed.
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
...s_negative_unit_tests/inventory/host_vars/duplicate-interfaces-point-to-point-services-4.yml
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Feb 7, 2025
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Update network_services/ethernet_interfaces.py to use classes
Component(s) name
arista.avd.eos_designsProposed changes
How to test
molecule does not change
Checklist
Repository Checklist