-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for Receive Side Scaling (RSS) interface profile #4954
Feat(eos_cli_config_gen): Add support for Receive Side Scaling (RSS) interface profile #4954
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4954
# Activate the virtual environment
source test-avd-pr-4954/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ashenoy-arista/avd.git@rssProfileSupport#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ashenoy-arista/avd.git#/ansible_collections/arista/avd/,rssProfileSupport --force
# Optional: Install AVD examples
cd test-avd-pr-4954
ansible-playbook arista.avd.install_examples |
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/rss_interface_profiles.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/rss_interface_profiles.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/rss_interface_profiles.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/rss_interface_profiles.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/rss_interface_profiles.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/rss_interface_profiles.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/rss_interface_profiles.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/rss_interface_profiles.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/rss_interface_profiles.schema.yml
Outdated
Show resolved
Hide resolved
e1e2b86
to
6b702e4
Compare
Currently unable to see newly added schema for Update: Resolved this issue after moving newly defined schema attributes under existing schema fragment file |
6b702e4
to
fe8edf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Only a minor question on data model.
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/platform.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/platform-sfe-interface.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/platform.schema.yml
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
0227d02
to
19fe8fe
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/platform-sfe-interface.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/platform-sfe-interface.j2
Outdated
Show resolved
Hide resolved
f9ba4ef
to
a675cd3
Compare
…interface profile
228122a
to
3eaa5af
Compare
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/platform.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/platform.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/platform.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/platform.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/platform.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/platform.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
…ne when scrolling and correlating the sections.
806c0d1
to
16ffa60
Compare
|
Add eos_cli_config_gen schema support for Receive Side Scaling (RSS) interface profile
Change Summary
Receive Side Scaling (RSS) interface profile schema to be later supported with jinja templates for generating EOS cli
Related Issue(s)
Fixes #4983
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Modeling the Receive Side Scaling (RSS) interface profile schema for eos_cli_config_gen
The associated CLI is supported on select hardware platforms namely -
CouncilBluffs platform - models AWE-5310 , AWE-7230R
Independence platform - models AWE-5510, AWE-7250R
There are two sets of CLI commands we need to target from schema perspective
Configure one or more RSS profiles
Apply specific RSS profile for platform
“show running-config” snippet
How to test
Ensure the generated EOS cli for RSS interface profile can be pasted without any error on supported hardware platform model such as AWE-5310 or AWE-5510
Please note, this needs feature-toggle "SfeRssCaravan" to be enabled on EOS device running latest trunk image (Jan 31 2025) => need to check with the team which EOS release this toggle will be enabled.
Pasted generated EOS cli with interface RSS profiles on supported platform such as CouncilBlufff AWE-5310-F
and issued "show run" and "show platform sfe interface profile" to validate output.
Checklist
User Checklist
Repository Checklist