Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Adjust class mixin layout and type hints #4922

Draft
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Related Issue(s)

Fixes #

Component(s) name

arista.avd.<role-name>

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4922
# Activate the virtual environment
source test-avd-pr-4922/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/class-mixin-layout-and-type-hints#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/class-mixin-layout-and-type-hints --force
# Optional: Install AVD examples
cd test-avd-pr-4922
ansible-playbook arista.avd.install_examples

@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/class-mixin-layout-and-type-hints branch from de8be06 to 6d5d9e6 Compare January 23, 2025 14:59
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 27, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: conflict PR with conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant