Feat(eos_designs): Added support for multicast ipv4 static on p2p uplinks ethernet #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4909
# Activate the virtual environment
source test-avd-pr-4909/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4228#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4228 --force
# Optional: Install AVD examples
cd test-avd-pr-4909
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
| @@ -156,6 +156,10 @@ $defs: | |||
| type: bool | |||
| description: Enable PIM sparse mode. Requires `include_in_underlay_protocol` and the global `underlay_multicast` to be `true`. | |||
| default: false | |||
| underlay_multicast_ipv4_static: | |||
There was a problem hiding this comment.
I think we should let this be a global knob, and then pick it up on all interfaces we classify as "underlay", so uplinks, mlag peer links and l3_edge/core_interfaces where include_in_underlay_protocol has been set.
There was a problem hiding this comment.
@sarunac @carlbuchmann please comment
There was a problem hiding this comment.
@ClausHolbechArista Maybe fine. It does simplify applying multicast static config on systems dedicated for static multicast.
But in systems that uses both static multicast and pim sparse mode, there should be a way to not apply the multicast static on links dedicated to pim sparse mode as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added support for multicast ipv4 static on p2p uplinks ethernet
Related Issue(s)
Fixes #4228
Component(s) name
arista.avd.eos_designsProposed changes
Added support for multicast ipv4 static on p2p uplinks ethernet interfaces.
How to test
Run Molecule
Checklist
User Checklist
Repository Checklist