Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improve readability #23

Merged
merged 10 commits into from
Nov 21, 2023
+62 −56
Merged

style: improve readability #23

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c3a8ff3
style: remove redundant .deref() invocations
arindas Oct 7, 2023
c8b5e84
style: correct local variable name to better reflect purpose
arindas Oct 7, 2023
5455dfc
style: renamed local var to reflect purpose better
arindas Oct 8, 2023
6949f22
style: shortened internal identifiers to ease reading
arindas Oct 8, 2023
b7c167d
refactor: avoid reading storage size multiple times
arindas Oct 9, 2023
6a8273f
chore: removes unecessary tarpaulin cfgs
arindas Oct 13, 2023
fd06c29
feat: represents metadata_bytes_len with a u32 in the serialized byte…
arindas Oct 13, 2023
926af41
refactor: rename Segment constructor to include all arguments
arindas Oct 14, 2023
c049c97
refactor: rename cache_index_records to cache_index_records_flag to b…
arindas Oct 22, 2023
4e9190f
refactor: inline index_cache_read_segments to clarify intent
arindas Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: avoid reading storage size multiple times
@arindas
arindas committed Oct 9, 2023
commit b7c167dcb9f2d504b936057b0b6c3c928c5624fc
8 changes: 3 additions & 5 deletions src/storage/commit_log/segmented_log/index.rs
View file
Original file line number Diff line number Diff line change
@@ -258,9 +258,9 @@ where
) -> Result<Vec<IndexRecord>, IndexError<S::Error>> {
let mut position = INDEX_BASE_MARKER_LENGTH as u64;

let mut index_records = Vec::<IndexRecord>::with_capacity(
Self::estimated_index_records_len_in_storage(storage)?,
);
let estimated_index_records_len = Self::estimated_index_records_len_in_storage(storage)?;

let mut index_records = Vec::<IndexRecord>::with_capacity(estimated_index_records_len);

while let Ok(index_record) =
PersistentSizedRecord::<IndexRecord, INDEX_RECORD_LENGTH>::read_at(
@@ -275,8 +275,6 @@ where

index_records.shrink_to_fit();

let estimated_index_records_len = Self::estimated_index_records_len_in_storage(storage)?;

if index_records.len() != estimated_index_records_len {
Err(IndexError::InconsistentIndexSize)
} else {