Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prerotate to application.j2 template #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guegrer
Copy link

@guegrer guegrer commented Mar 5, 2020

would be great to add prerotate :) ,thanks.

@guegrer
Copy link
Author

guegrer commented Mar 5, 2020

i would like to know why the Travis CI failed to build thanks...

Copy link
Author

@guegrer guegrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add prerotate to logrotate.conf

@sbaerlocher sbaerlocher self-requested a review March 10, 2020 07:08
@sbaerlocher
Copy link
Member

That looks good, could you add the change to the changelog?

The problem with the pipline is that molecule has made a change in the latest version[1] Can you still change it?

[1]https://molecule.readthedocs.io/en/latest/configuration.html#lint

@sbaerlocher sbaerlocher self-assigned this Mar 10, 2020
@neilyoung
Copy link

Too bad. Missing "prerotate" support disqualifies this (otherwise) well working role

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants