Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ethereum): Release 1.0.2 #174

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This is an automated release PR for version 1.0.2 of the ethereum light client.

On merge, this will trigger the release publish workflow, which will upload a new GitHub release with tag ethereum-v1.0.2.

Workflow run

@wwared wwared self-requested a review August 19, 2024 17:08
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple revert, LGTM. @samuelburnham what would happen with the release workflow today? (I'm asking about #166)

@samuelburnham
Copy link
Member

Simple revert, LGTM. @samuelburnham what would happen with the release workflow today? (I'm asking about #166)

There shouldn't be any issue with this hotfix release as it's merging into the release branch. #166 refers to the need to change new releases to merge into e.g. main rather than dev as they will pin the Sphinx versions to a release, and we want ZKLC dev to continue using Sphinx dev.

Copy link
Contributor

@wwared wwared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking because #177 fixes this without reverting #123. Will update the hotfix branch with the fix shortly

wwared and others added 3 commits August 20, 2024 11:57
* chore: Add `large_futures` clippy lint to xclippy

* fix: Use `Box::pin` to heap allocate large futures

---------

Co-authored-by: wwared <[email protected]>
@wwared wwared force-pushed the hotfix/ethereum-v1.0.2 branch from ec4842e to ffb6fb4 Compare August 20, 2024 15:00
@wwared wwared self-requested a review August 20, 2024 15:00
@wwared wwared requested a review from tchataigner August 20, 2024 15:01
Copy link
Contributor

@tchataigner tchataigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Re-adds the BUSL exceptions to deny.toml for the aptos-lc crates
@wwared wwared requested a review from tchataigner August 20, 2024 16:11
@tchataigner tchataigner merged commit cf15026 into release/ethereum-v1.0 Aug 20, 2024
9 checks passed
@tchataigner tchataigner deleted the hotfix/ethereum-v1.0.2 branch August 20, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants