ci: Test fixture-generator
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelburnham
force-pushed
the
ci-fixture-generator
branch
12 times, most recently
from
59e3fdd to
260d4b5
Compare
huitseeker
approved these changes
Aug 18, 2024
| @@ -120,6 +137,7 @@ confidence-threshold = 0.8 | |||
| # aren't accepted for every possible crate as with the normal allow list | |||
| exceptions = [ | |||
| # Each entry is the crate and version constraint, and its specific allow list. | |||
| { name = "number_range", version = "0.3.2", allow = ["GPL-3.0"] } | |||
There was a problem hiding this comment.
Please link to aptos-labs/aptos-core#13931: we should be able to remove this as soon as we upgrade the aptos-node fork
samuelburnham
force-pushed
the
ci-fixture-generator
branch
from
2a74012 to
53d09c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.github/workflows/rust.ymlto run clippy on thefixture-generatorcrate when its source code or either ofaptos/ethereum's code is changed on a pull request. Skips running tests (since there are no unit tests currently) or the cycle count checker onfixture-generator.fail-fast: falseso they aren't cancelled if another job fails.cargo denyforfixture-generatortemporarily, but it's unclear why the check was failing while it succeeded foraptosandethereum.Successful runs:
fixture-generatorchange: https://github.com/argumentcomputer/zk-light-clients/actions/runs/10442273772ethereumchange: https://github.com/argumentcomputer/zk-light-clients/actions/runs/10442557465Fixes #152