ci: refactor release flow #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,28 +47,28 @@ jobs: | |||
| - name: Install `tq-rs` | |||
| run: cargo install tq-rs | |||
|
|
|||
| # The `release/1.0` branch is always truncated, so that patch version merges still are valid Semver | |||
| # However, when we make the initial `release/1.0` version bump, we include the full `1.0.0` in `Cargo.toml` | |||
| # The `release/light-client-v1.0` branch is always truncated, so that patch version merges still are valid Semver | |||
There was a problem hiding this comment.
Nit: The branch name is either release/aptos-v1.0 or release/ethereum-v1.0, so we could document something like release/<light-client>-v1.0 or release/<aptos|ethereum>-v1.0
Co-authored-by: Samuel Burnham <[email protected]>
wwared
approved these changes
Jul 29, 2024
samuelburnham
approved these changes
Jul 29, 2024
tchataigner
added a commit
that referenced
this pull request
Jul 30, 2024
* ci: refactor release flow * refactor: apply suggestions Co-authored-by: Samuel Burnham <[email protected]> * refactor: integrate review --------- Co-authored-by: Samuel Burnham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalizes #55. It refactors the Bump Version and Tag workflow to work with multiple Light Client implementations.
Changelog
release/*branches (e.g.:release/aptos-v1.0) and the associated tags to specify which Light Client is targetedRelated issue
Closes #55