add flag to enable MD5 checksum for S3 upload #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akloss-cibo
force-pushed
the
add-content-md5-header
branch
from
d002fe1 to
d2ac3e6
Compare
cibo-admin
approved these changes
Jan 21, 2025
3 tasks
tczhao
requested changes
Jan 23, 2025
s3/s3.go
Outdated
| @@ -91,6 +91,7 @@ type S3ClientOpts struct { | |||
| RoleSessionName string | |||
| UseSDKCreds bool | |||
| EncryptOpts EncryptOpts | |||
| EnableMD5 bool | |||
There was a problem hiding this comment.
Since the api description in minio is
Specify if you’d like to send content-md5 header with PutObject operation. Note that setting this flag will cause higher memory usage because of in-memory md5sum calculation.
I probably keep this variable as SendContentMd5, it describe what the variable is doing more accurately.
Other variables in S3ClientOpts struct uses the same name if they also present in MinIO
This checksum is required if a bucket has Object Lock enabled by default. addresses argoproj/argo-workflows#11182 Signed-off-by: Alec Kloss <[email protected]>
akloss-cibo
force-pushed
the
add-content-md5-header
branch
from
d2ac3e6 to
a422af0
Compare
|
tczhao
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checksum is required if a bucket has Object Lock enabled by default.
addresses argoproj/argo-workflows#11182