build: fix mkdir /home/vscode/go/pkg: permission denied
#14162
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rebuilding the dev container, I'm getting the following: ``` Running the postCreateCommand from devcontainer.json... [12542 ms] Start: Run in container: /bin/sh -c .devcontainer/pre-build.sh <SNIP> + make kit GIT_COMMIT=a776b4583972625541a358b3c9a2e1fdc0925763 GIT_BRANCH=main GIT_TAG=untagged GIT_TREE_STATE=dirty RELEASE_TAG=false DEV_BRANCH=false VERSION=latest KUBECTX=k3d-k3s-default K3D=true DOCKER_PUSH=false TARGET_PLATFORM=linux/amd64 RUN_MODE=local PROFILE=minimal AUTH_MODE=hybrid SECURE=false STATIC_FILES=true ALWAYS_OFFLOAD_NODE_STATUS=false UPPERIO_DB_DEBUG=0 LOG_LEVEL=debug NAMESPACED=true go install github.com/kitproj/[email protected] go: go: could not create module cache: mkdir /home/vscode/go/pkg: permission denied make: *** [Makefile:535: kit] Error 1 [21801 ms] postCreateCommand from devcontainer.json failed with exit code 2. Skipping any further user-provided commands. ``` I think this was introduced with argoproj#14105, and the fix is to move `make kit` to be after the `chown` lines. Signed-off-by: Mason Malone <[email protected]>
alexec
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When rebuilding the dev container, I'm getting the following:
This causes the rest of
pre-build.shto be skipped, which means the container will be missingkitModifications
I think this was introduced with #14105, and the fix is to move
make kitto be after thechownlines.Verification
Rebuilt dev container locally
Documentation
N/A