Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-cd): Fix REDIS_PASSWORD optional flag #3058

Merged
merged 3 commits into from
Nov 28, 2024
Merged

fix(argo-cd): Fix REDIS_PASSWORD optional flag #3058

merged 3 commits into from
Nov 28, 2024

Conversation

bhavinkotak
Copy link
Contributor

@bhavinkotak bhavinkotak commented Nov 27, 2024 •
edited
Loading

Should fix this Issue

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@tico24
Copy link
Member

tico24 commented Nov 27, 2024

You'll need to argue with DCO to get it to merge but overall approved by me.

@bhavinkotak bhavinkotak force-pushed the redis_password_optional_fix branch from 0ee2fb8 to 4dda94d Compare November 27, 2024 20:47
@bhavinkotak
Copy link
Contributor Author

DCO is fixed now.. sorry for the earlier miss..

@yu-croco yu-croco merged commit 07c5b5d into argoproj:main Nov 28, 2024
6 checks passed
@mkilchhofer
Copy link
Member

mkilchhofer commented Nov 28, 2024 •
edited
Loading

@yu-croco @mbevc1 @tico24 we already were there. Sorry for not being more active on this PR. Now an other use case is broken ;)

@mbevc1
Copy link
Collaborator

mbevc1 commented Nov 28, 2024

Ah, forgot about that one 😅

@yu-croco
Copy link
Collaborator

ahhhhh 🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico24 tico24 tico24 approved these changes

@yu-croco yu-croco yu-croco approved these changes

@mbevc1 mbevc1 mbevc1 approved these changes

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

Assignees
No one assigned
Labels
argo-cd size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavinkotak @tico24 @mkilchhofer @mbevc1 @yu-croco