Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-cd): Add rights on applicationsets for application controller #2975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

fix(argo-cd): Add rights on applicationsets for application controller #2975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/argo-cd/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v2.12.4
kubeVersion: ">=1.25.0-0"
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd
version: 7.6.8
version: 7.6.9
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
sources:
Expand All @@ -27,4 +27,4 @@ annotations:
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: added
description: Set affinity in redis secret-init job.
description: Add rights on applicationsets for application controller.
4 changes: 4 additions & 0 deletions charts/argo-cd/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@ For full list of changes please check ArtifactHub [changelog].

Highlighted versions provide information about additional steps that should be performed by user when upgrading to newer version.

### 7.6.9

We have added the permission for the application controller on the applicationsets, to be able to create them in the target clusters.

### 7.0.0

We changed the type of `.Values.configs.clusterCredentials` from `list` to `object`.
Expand Down
4 changes: 4 additions & 0 deletions charts/argo-cd/README.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@ For full list of changes please check ArtifactHub [changelog].

Highlighted versions provide information about additional steps that should be performed by user when upgrading to newer version.

### 7.6.9

We have added the permission for the application controller on the applicationsets, to be able to create them in the target clusters.

### 7.0.0

We changed the type of `.Values.configs.clusterCredentials` from `list` to `object`.
Expand Down
1 change: 1 addition & 0 deletions charts/argo-cd/templates/argocd-application-controller/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ rules:
- argoproj.io
resources:
- applications
- applicationsets
Copy link
Collaborator

@yu-croco yu-croco Oct 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OpenGuidou , thank you for your PR.
Since we follow upstream and we don't see the permission in v2.12.4. 🤔
Ref: https://github.com/argoproj/argo-cd/blob/v2.12.4/manifests/base/application-controller-roles/argocd-application-controller-role.yaml

Can you please make PR for upstream ? Once upstream releases as a new version, we also follow this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure !

- appprojects
verbs:
- create
Expand Down