Fix import failures of THAPI-spack with the latest version of spack #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thilinarmtb
commented
Jan 31, 2025
| from spack import * | ||
|
|
||
|
|
||
| from spack.package import * |
There was a problem hiding this comment.
Feels like the formatting is wrong here (missing blank lines before the class declaration).
But spack style -f didn't find any formatting errors.
There was a problem hiding this comment.
# Copyright Spack Project Developers. See COPYRIGHT file for details.
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
from spack.package import *
class Davix(CMakePackage):
Look like is the canonical way 🤷🏽
thilinarmtb
force-pushed
the
fix-import
branch
from
13b2899 to
cd42025
Compare
TApplencourt
approved these changes
Jan 31, 2025
|
Does those change make fixed all the spack issue on polaris? |
Yes, they do. I was able to install THAPI with these changes. |
|
Nice! The CI passed, so let's merge. We can take care of the syntax formatting another time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.