forked from greenplum-db/gpdb-archive
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBDEV-5527: Explain Analyze doesn't show statistics for queries with DML inside CTE #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mos65o2
pushed a commit
that referenced
this pull request
Jan 10, 2025
In vanilla PG and Greenplum queries containing modifying CTE are executed with portal strategy PORTAL_ONE_MOD_WITH, which involves storing the result of the query in portal's tuple store, which the final result is then fetched from. This strategy is fair enough and helps us avoid executing modifying operation several times, for example, when one need to fetch the query result partially. However, in Greenplum case executing this strategy at QE nodes is redundant, because clients communicate with the system throught the QD node. Therefore, this commit proposes another type of strategy for execution at QE nodes. Moreover, when a query contains modifying CTE, EXPLAIN ANALYZE reports most of plan nodes as "never executed", even though the corresponding nodes have been fully executed and have returned the tuples. This problem arise because of PORTAL_ONE_MOD_WITH execution strategy, according to which the extra pq message with tuple description is sent to QD, and the statistics can't be retrieved properly in cdbexplain_recvExecStats function. (cherry picked from commit c9b7b02)
mos65o2
pushed a commit
that referenced
this pull request
Jan 10, 2025
In vanilla PG and Greenplum queries containing modifying CTE are executed with portal strategy PORTAL_ONE_MOD_WITH, which involves storing the result of the query in portal's tuple store, which the final result is then fetched from. This strategy is fair enough and helps us avoid executing modifying operation several times, for example, when one need to fetch the query result partially. However, in Greenplum case executing this strategy at QE nodes is redundant, because clients communicate with the system throught the QD node. Therefore, this commit proposes another type of strategy for execution at QE nodes. Moreover, when a query contains modifying CTE, EXPLAIN ANALYZE reports most of plan nodes as "never executed", even though the corresponding nodes have been fully executed and have returned the tuples. This problem arise because of PORTAL_ONE_MOD_WITH execution strategy, according to which the extra pq message with tuple description is sent to QD, and the statistics can't be retrieved properly in cdbexplain_recvExecStats function. (cherry picked from commit c9b7b02)
Please specify changes from the original commit in the new commit description (just "updated test outputs and matchsubs", if I didn't miss anything else) |
In vanilla PG and Greenplum queries containing modifying CTE are executed with portal strategy PORTAL_ONE_MOD_WITH, which involves storing the result of the query in portal's tuple store, which the final result is then fetched from. This strategy is fair enough and helps us avoid executing modifying operation several times, for example, when one need to fetch the query result partially. However, in Greenplum case executing this strategy at QE nodes is redundant, because clients communicate with the system throught the QD node. Therefore, this commit proposes another type of strategy for execution at QE nodes. Moreover, when a query contains modifying CTE, EXPLAIN ANALYZE reports most of plan nodes as "never executed", even though the corresponding nodes have been fully executed and have returned the tuples. This problem arise because of PORTAL_ONE_MOD_WITH execution strategy, according to which the extra pq message with tuple description is sent to QD, and the statistics can't be retrieved properly in cdbexplain_recvExecStats function. Changes cherry-pick commit: updated test outputs and matchsubs. (cherry picked from commit c9b7b02)
silent-observer
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bimboterminator1
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the portal strategy for modifying CTE case
In vanilla PG and Greenplum queries containing modifying CTE are executed
with portal strategy PORTAL_ONE_MOD_WITH, which involves storing the result
of the query in portal's tuple store, which the final result is then fetched
from. This strategy is fair enough and helps us avoid executing
modifying operation several times, for example, when one need to fetch
the query result partially. However, in Greenplum case executing this
strategy at QE nodes is redundant, because clients communicate with the
system throught the QD node. Therefore, this commit proposes another
type of strategy for execution at QE nodes.
Moreover, when a query contains modifying CTE, EXPLAIN ANALYZE reports most of
plan nodes as "never executed", even though the corresponding nodes have been
fully executed and have returned the tuples. This problem arise because
of PORTAL_ONE_MOD_WITH execution strategy, according to which the extra
pq message with tuple description is sent to QD, and the statistics
can't be retrieved properly in cdbexplain_recvExecStats function.
Changes cherry-pick commit: updated test outputs and matchsubs.
(cherry picked from commit c9b7b02)
Commits in the PR shouldn't be squashed to preserve authorship.