forked from greenplum-db/gpdb-archive
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBDEV-5705: Fix direct dispatch behavior with ShareInputScan #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stolb27
reviewed
Dec 17, 2024
Stolb27
reviewed
Dec 18, 2024
Stolb27
reviewed
Dec 18, 2024
Stolb27
reviewed
Dec 18, 2024
Stolb27
reviewed
Dec 18, 2024
RekGRpth
reviewed
Dec 19, 2024
RekGRpth
approved these changes
Dec 20, 2024
Stolb27
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix direct dispatch behavior with ShareInputScan
When direct dispatch optimization is enabled for shared CTEs (resulting in
ShareInputScan plan nodes), a deadlock could occur because of mismatch between
the segments on producer and consumer. This was happening because direct
dispatch list wasn't copied to the consumer when CTE was planned. However, the
issue is deeper than just that: it is possible that ShareInputScans executing
on different slices actually need different direct dispatch segments because
of other parts of the query executing on those slices. For example, if CTE is
UNION
ed with another simple query that can be directly dispatched, it canaffect the direct dispatch list of that slice. However, since direct dispatch
lists should match for ShareInputScans, the direct dispatch lists should
actually be combined to preserve the correct behaviour. This issue is only
present for the Postgres optimizer, since ORCA doesn't seem to have any
optimizations equivalent to direct dispatch.
This patch adds a new fix to the apply_shareinput_xslice. During the first
pass we collect the merged direct dispatch info from all SharedInputScan's
invocations, and then during the second pass we replace their direct dispatch
info with the merged one. If the SharedInputScan wasn't actually shared or if
it wasn't cross-slice, this is a no-op since only one direct dispatch info is
present, so merging doesn't change anything.