Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor endpoints initialization for Browser component #2722

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

zeezo887
Copy link
Collaborator

@zeezo887 zeezo887 commented Feb 4, 2025

Description

This change aims to fix the initialization of the endpoints property when passed to the Browser component. Initially, we have

$this->endpoints = $this->endpoints === [] ? $endpointsFromModules ?? [] : [];

which always sets $endpoints to an empty array when a value is passed. The changes made here includes

  • Removed the extra variable $endpointsFromModules, simplifying the assignment.
  • and only re-assigning the $endpoints property if it is empty and if $this->modules exists.

Related Issues

Fixes #2717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formview <x-twill::browser> not honoring the :endpoints parameter properly
1 participant