Fixes incorrect order of nested items when item is more than 2 levels deep #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to build the ancestor slug properly
ifox
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Thanks @pauldwight, really appreciate you jumping on this!
This looks like the appropriate solution, just made a minor suggestion.
I looked at the history of this method and it looks like we got it wrong a couple of times and that the confusion came from the fact that it used to depend on the order of record creation.
ifox
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect order of nested items when item is more than 2 levels deep.
Description
The getAncestors() from the nestedset package doesn't set any default order which means that the ancestors returned are in order of creation (id) rather than hierarchical order.
Rather than making the assumption as to what order the ancestor items were created it is better to sort the collection by the _lft column (as the defaultOrder() method does in the package).
See https://github.com/lazychaser/laravel-nestedset#ancestors-and-descendants for more info.
Related Issues
Fixes #2387 #2302 #2280