Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network upload #878

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Remove network upload #878

merged 2 commits into from
Dec 18, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Dec 15, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

remove Network Upload

  • What is the current behavior?

The Network Upload is a functionality that has been implemented to support the Arduino Yun, since the board reached it's EOL stage we are removing the functionality.

  • What is the new behavior?

The Arduino Yun is no more supported

  • Does this PR introduce a breaking change?

Yes

  • Other information:

@umbynos umbynos added the topic: security Related to the protection of user data label Dec 15, 2023
@umbynos umbynos self-assigned this Dec 15, 2023
@umbynos umbynos force-pushed the remove-network-upload branch from e134057 to d401eca Compare December 15, 2023 16:21
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (0fd774a) 19.93% compared to head (d401eca) 19.99%.

Files Patch % Lines
serial.go 0.00% 4 Missing ⚠️
serialport.go 0.00% 4 Missing ⚠️
conn.go 0.00% 1 Missing ⚠️
hub.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   19.93%   19.99%   +0.05%     
==========================================
  Files          44       43       -1     
  Lines        3626     3366     -260     
==========================================
- Hits          723      673      -50     
+ Misses       2809     2601     -208     
+ Partials       94       92       -2     
Flag Coverage Δ
unit 19.99% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umbynos umbynos marked this pull request as draft December 15, 2023 16:25
@umbynos umbynos marked this pull request as ready for review December 15, 2023 16:33
Copy link

@rhpco rhpco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@umbynos umbynos merged commit fb135b0 into main Dec 18, 2023
47 checks passed
@umbynos umbynos deleted the remove-network-upload branch December 18, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: security Related to the protection of user data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants