Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused endpoint #877

Merged
merged 1 commit into from
Dec 15, 2023
Merged

remove unused endpoint #877

merged 1 commit into from
Dec 15, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Dec 15, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

remove unused endpoint

  • What is the current behavior?

the killbrowser endpoint was used to kill the browser after the certificate installation

  • What is the new behavior?

we do not need this endpoint anymore

  • Does this PR introduce a breaking change?

technically yes, but the endpoint is unused

  • Other information:

@umbynos umbynos added the type: enhancement Proposed improvement label Dec 15, 2023
@umbynos umbynos self-assigned this Dec 15, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d362b2) 19.68% compared to head (5c77a0c) 19.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   19.68%   19.93%   +0.24%     
==========================================
  Files          46       44       -2     
  Lines        3672     3626      -46     
==========================================
  Hits          723      723              
+ Misses       2855     2809      -46     
  Partials       94       94              
Flag Coverage Δ
unit 19.93% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@umbynos umbynos merged commit 0fd774a into main Dec 15, 2023
58 checks passed
@umbynos umbynos deleted the remove-killbrowser branch December 15, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants