Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start-time of WebApi request-tracking #334

Merged
merged 5 commits into from
Jun 23, 2022
Merged

Fix start-time of WebApi request-tracking #334

merged 5 commits into from
Jun 23, 2022

Conversation

fgheysels
Copy link
Member

@fgheysels fgheysels commented Jun 8, 2022

The RequestTracking middleware was not logging the correct start date/time. Instead of the actual start date and time of the request , the current date/time was used.

#333

@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview for arcus-webapi canceled.

Name Link
🔨 Latest commit 5d38585
🔍 Latest deploy log https://app.netlify.com/sites/arcus-webapi/deploys/62b4157d18d07b000875cfe2

@fgheysels
Copy link
Member Author

Before this PR can be closed, we first need to release a new version of Arcus.Observability which must then be referenced here.

@stijnmoreels
Copy link
Member

Before this PR can be closed, we first need to release a new version of Arcus.Observability which must then be referenced here.

Yes, that's why I haven't created a PR just yet 😄 .

@fgheysels
Copy link
Member Author

Before this PR can be closed, we first need to release a new version of Arcus.Observability which must then be referenced here.

Yes, that's why I haven't created a PR just yet 😄 .

That's why it is also in draft :)

Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change the non .NET 6 packages too, as this is actually a fix for request tracking.

src/Arcus.WebApi.Logging/Arcus.WebApi.Logging.csproj Outdated Show resolved Hide resolved
@stijnmoreels stijnmoreels marked this pull request as ready for review June 23, 2022 05:43
Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thx for this! 👍

@stijnmoreels stijnmoreels merged commit a58d07c into arcus-azure:master Jun 23, 2022
@stijnmoreels stijnmoreels linked an issue Jun 24, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request Middleware is not logging the correct timestamp
2 participants