Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add the RemoveMicrosoftApplicationInsightsLoggerProvider extension to all Serilog infrastructure code (🚧) #607

Closed
wants to merge 13 commits into from
Closed

feat: Add the RemoveMicrosoftApplicationInsightsLoggerProvider extension to all Serilog infrastructure code (🚧) #607

wants to merge 13 commits into from

Conversation

vincenttermaat
Copy link
Contributor

Add the RemoveMicrosoftApplicationInsightsLoggerProvider extension to all Serilog infrastructure code.
Closes #604

@netlify
Copy link

netlify bot commented Jun 20, 2022 •
edited
Loading

👷 Deploy request for arcus-templates pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 09a4614

@stijnmoreels stijnmoreels changed the title feat: Add the RemoveMicrosoftApplicationInsightsLoggerProvider extension to all Serilog infrastructure code feat: Add the RemoveMicrosoftApplicationInsightsLoggerProvider extension to all Serilog infrastructure code (🚧) Jun 20, 2022
stijnmoreels
stijnmoreels requested changes Jun 20, 2022
View reviewed changes
Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Vincent! 🥇 Thx or this. Let's wait until we have the observability fully released so we can update this PR with the next minor. But already great job in helping us here!

src/Arcus.Templates.AzureFunctions.Databricks.JobMetrics/Startup.cs Outdated Show resolved Hide resolved
@stijnmoreels stijnmoreels marked this pull request as draft June 21, 2022 05:33
stijnmoreels
stijnmoreels requested changes Jun 22, 2022
View reviewed changes
Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 👍 Thx for fixing.
Let's see if we can release observability this week.

src/Arcus.Templates.AzureFunctions.Databricks.JobMetrics/Startup.cs Outdated Show resolved Hide resolved
src/Arcus.Templates.AzureFunctions.Http/Startup.cs Outdated Show resolved Hide resolved
src/Arcus.Templates.AzureFunctions.ServiceBus.Queue/Startup.cs Outdated Show resolved Hide resolved
src/Arcus.Templates.AzureFunctions.ServiceBus.Topic/Startup.cs Outdated Show resolved Hide resolved
@vincenttermaat vincenttermaat deleted the branch arcus-azure:master June 22, 2022 09:37
@vincenttermaat vincenttermaat deleted the master branch June 22, 2022 09:37
@vincenttermaat vincenttermaat restored the master branch June 22, 2022 09:38
@vincenttermaat vincenttermaat mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stijnmoreels stijnmoreels stijnmoreels requested changes

@fgheysels fgheysels Awaiting requested review from fgheysels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vincenttermaat @stijnmoreels