Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arcus template for HTTP-Triggered Function App]: Warning deprecated & Error when upgraded to Arcus version 2.4 #575

Closed
ACA-CDT opened this issue Apr 29, 2022 · 7 comments
Assignees

Comments

@ACA-CDT
Copy link

ACA-CDT commented Apr 29, 2022

Describe the bug
For the new Monitoring I use an Arcus template for a HTTP-triggered Azure Function. Arcus version 2.2.2 works well in .Net Core 3.1 and .Net 6.0, but there's a deprecated warning in one of the NuGet packages of Arcus:
image

  • when I upgrade the Arcus NuGet Packages to Arcus version 2.4, an error and warning is shown on these lines:
    image

image

To Reproduce

Expected behavior
If possible, a plug-and-play Function App Arcus project template for .Net Core 3.1 & .NET 6.0 with the last versions of Arcus without deprecated packages or code marked as obsolete

@pim-simons
Copy link
Contributor

Don't replace the Arcus.Observability.Telemetry.AzureFunctions package just yet, see also arcus-azure/arcus.observability#364

@stijnmoreels
Copy link
Member

Thx for mentioning. The two packages mentioned are already under consideration. At the moment, we can't update the HTTP correlation extension because we are migrating towards another one and will only be available in v2.0 of Arcus WebAPI. The other extension is also under consideration is will possibly be made 'undeprecated' like Pim said.

@stijnmoreels
Copy link
Member

stijnmoreels commented Apr 29, 2022

Since the templates are not yet updated all to .NET 6 and we haven't released v0.8, I think this is not a bug as it's still WIP.

@ACA-CDT
Copy link
Author

ACA-CDT commented Apr 29, 2022

Ok, Thx, I'll keep it in mind.

@stijnmoreels
Copy link
Member

@fgheysels , will we provide default-provided options so to guide consumers to the non-deprecated variant?

@stijnmoreels
Copy link
Member

We could actually also move the currently located HttpCorrelationInfoOptions.Upstream property in Web API to the CorrelationInfoOptions in Observability library, as upstream services can be used outside Web API applications, that way we could actually remove back the HttpCorrelationInfoOptions, and refactor the optional argument extension to method overloading without waiting for the next major.

@stijnmoreels
Copy link
Member

@ACA-CDT , we updated the project templates to .NET 6 and the next version v1.1 will also include the new W3C correlation. Normally, any package deprecation issues should be fixed now. Can we close this?

@ACA-CDT ACA-CDT closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants