Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP triggered Function template is still using the obsolete AddHttpCorrelation extension method #601

Closed
pim-simons opened this issue Jun 8, 2022 · 3 comments · Fixed by #637
Closed

HTTP triggered Function template is still using the obsolete AddHttpCorrelation extension method #601

pim-simons opened this issue Jun 8, 2022 · 3 comments · Fixed by #637
Assignees
@stijnmoreels
Labels
enhancement New feature or request runtime:azure-functions All issues related to templates forAzure Functions
Milestone
v1.0

Comments

@pim-simons
Copy link
Contributor

When creating a new HTTP triggered Function project (https://templates.arcus-azure.net/features/azurefunctions-http-template/) , the project is still using the now obsolete AddHttpCorrelation() extension method: builder.AddHttpCorrelation();.

This should be changed to the non-obsolete version.
Related to #538 but now applied to the HTTP triggered Function project.
@pim-simons pim-simons added enhancement New feature or request runtime:azure-functions All issues related to templates forAzure Functions labels Jun 8, 2022
@stijnmoreels
Copy link
Member

stijnmoreels commented Jun 8, 2022 •
edited
Loading

Yeah, that's a pickle.

Also related to #575

@stijnmoreels stijnmoreels added this to the v0.9 milestone Jun 8, 2022
@fgheysels
Copy link
Member

I think these issues need to be picked up with prio, and a new release should be created as soon as possible then.

@stijnmoreels stijnmoreels mentioned this issue Jun 9, 2022
Merged
@stijnmoreels stijnmoreels self-assigned this Aug 1, 2022
@stijnmoreels stijnmoreels linked a pull request Aug 1, 2022 that will close this issue
feat: use appinsights connectionstring in http trigger #637
Merged
@stijnmoreels
Copy link
Member

Updated to Arcus.WebApi v1.6 which fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
enhancement New feature or request runtime:azure-functions All issues related to templates forAzure Functions
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

feat: use appinsights connectionstring in http trigger stijnmoreels/arcus.templates
3 participants
@fgheysels @stijnmoreels @pim-simons