feat: add extension to rm microsoft appinsights logprovider #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for arcus-observability ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
stijnmoreels
changed the title
stijnmoreels
changed the title
stijnmoreels
commented
May 23, 2022
...servability.Tests.Integration/Serilog/Sinks/ApplicationInsights/AzureFunctionsDockerTests.cs
Show resolved
Hide resolved
fgheysels
reviewed
May 23, 2022
src/Arcus.Observability.Telemetry.AzureFunctions/Extensions/ILoggerBuilderExtensions.cs
Show resolved
Hide resolved
...servability.Tests.Integration/Serilog/Sinks/ApplicationInsights/AzureFunctionsDockerTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Frederik Gheysels <[email protected]>
…ationInsights/AzureFunctionsDockerTests.cs Co-authored-by: Frederik Gheysels <[email protected]>
|
/azp run CI - Arcus.Observability |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fgheysels
approved these changes
May 31, 2022
Co-authored-by: Frederik Gheysels <[email protected]>
stijnmoreels
deleted the
feature/add-extension-to-remove-microsoft-appinsights-loggerprovider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dedicated extension to remove Microsoft's
ApplicationInsightsLoggerProviderto ensure that Arcus is in full control of telemetry.Closes #364