Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace compile-time package access fixing on Forge with Unprotect #84

Merged
merged 2 commits into from
May 4, 2022

Conversation

Juuxel
Copy link
Member

@Juuxel Juuxel commented May 3, 2022

Unprotect does it at runtime as a ModLauncher plugin and also doesn't suffer from FabricMC/tiny-remapper#92.

  • Test with 1.16.5
  • Test with 1.18.2

@Juuxel Juuxel changed the title Remove compile-time package access fixing on Forge Replace compile-time package access fixing on Forge with Unprotect May 3, 2022
@Juuxel Juuxel marked this pull request as ready for review May 3, 2022 16:07
Copy link
Member

@shedaniel shedaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@shedaniel shedaniel merged commit 514ba75 into architectury:dev/0.11.0 May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants