Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffrent solvers and Precond. for Hypre #216

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Conversation

mohd-afeef-badri
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 88.70968% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (18c6627) to head (1170d0e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
femutils/HypreDoFLinearSystem.cc 88.70% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   72.40%   72.51%   +0.10%     
==========================================
  Files          62       62              
  Lines        9593     9674      +81     
  Branches     1147     1147              
==========================================
+ Hits         6946     7015      +69     
- Misses       2304     2316      +12     
  Partials      343      343              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@grospelliergilles grospelliergilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the development.
Maybe we can use an enumeration for the type of the solver in the CaseOption to make sure the value is correct. At the moment this is a string and the user may use an invalid name

@mohd-afeef-badri
Copy link
Collaborator Author

mohd-afeef-badri commented Jan 30, 2025

Maybe we can use an enumeration for the type of the solver in the CaseOption to make sure the value is correct. At the moment this is a string and the user may use an invalid name

@grospelliergilles Thanks for this suggestion. I have done so in fd31ad9. Is it ok for you to merge.

HYPRE_BiCGSTABSetPrintLevel(solver, m_verbosity); // print solve info //
HYPRE_BiCGSTABSetLogging(solver, 1); // needed to get run info later //
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a ARCANE_FATAL() if the solver name is not handled.

BADRI Mohd-Afeef 258512 and others added 2 commits January 31, 2025 18:03
@mohd-afeef-badri mohd-afeef-badri merged commit bf99185 into main Jan 31, 2025
2 checks passed
@mohd-afeef-badri mohd-afeef-badri added enhancement New feature or request test labels Feb 2, 2025
@mohd-afeef-badri mohd-afeef-badri self-assigned this Feb 2, 2025
@mohd-afeef-badri mohd-afeef-badri linked an issue Feb 2, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GMRES GPU support with Hypre
2 participants