-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diffrent solvers and Precond. for Hypre #216
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 72.40% 72.51% +0.10%
==========================================
Files 62 62
Lines 9593 9674 +81
Branches 1147 1147
==========================================
+ Hits 6946 7015 +69
- Misses 2304 2316 +12
Partials 343 343 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the development.
Maybe we can use an enumeration for the type of the solver in the CaseOption to make sure the value is correct. At the moment this is a string and the user may use an invalid name
@grospelliergilles Thanks for this suggestion. I have done so in fd31ad9. Is it ok for you to merge. |
femutils/HypreDoFLinearSystem.cc
Outdated
HYPRE_BiCGSTABSetPrintLevel(solver, m_verbosity); // print solve info // | ||
HYPRE_BiCGSTABSetLogging(solver, 1); // needed to get run info later // | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a ARCANE_FATAL()
if the solver name is not handled.
No description provided.