[No.129]Function with the ability to select cells (Data filter B… #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanglevinh
changed the title
sanglevinh
requested review from
emuemuJP,
itutu-tienday,
milesAraya and
tsuchiyama-araya
itutu-tienday
requested changes
Jan 6, 2025
frontend/src/components/Workspace/FlowChart/FlowChartNode/AlgorithmNode.tsx
Show resolved
Hide resolved
frontend/src/components/Workspace/FlowChart/FlowChartNode/AlgorithmNode.tsx
Show resolved
Hide resolved
…w' into feature/516
milesAraya
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Currently the filter box has bugs in the input
- Cannot delete "0"
- Cannot input commas into ROI
- Actual data dims should be used for placeholders
- Filter box parameters are not passed to the subsequent analysis. This is the whole point of the filter box. If dim 1:500 is selected, only that data should be used for the next step of analysis. This will allow users to save time by only performing analysis on certain important sections of the data. For PCA it will also change the results. This is a top priority.
- Fluorescence and ROI windows should be shown simultaneously and side-by-side (this is lower priority as user could still manage to use the filter box without this. However, it was still in the request)
frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx
Outdated
Show resolved
Hide resolved
itutu-tienday
requested changes
Jan 7, 2025
frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Workspace/FlowChart/FlowChartNode/AlgorithmNode.tsx
Show resolved
Hide resolved
frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx
Outdated
Show resolved
Hide resolved
sanglevinh
force-pushed
the
feature/516
branch
from
2e137de to
7b904a4
Compare
sanglevinh
force-pushed
the
feature/516
branch
from
d33afaf to
3ecd176
Compare
itutu-tienday
requested changes
Feb 18, 2025
frontend/src/components/Workspace/FlowChart/Dialog/BoxFilter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Workspace/FlowChart/FlowChartNode/AlgorithmNode.tsx
Outdated
Show resolved
Hide resolved
Sorry for the late check. I have fixed everything. Could you please test it again? |
itutu-tienday
approved these changes
Feb 19, 2025
milesAraya
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[No.129]Function with the ability to select cells (Data filter Button) #516