feat(ProfessionNPC): correct get skill_name

araxiaonline · Oct 22, 2021 · 7487995 · 7487995
1 parent 2898ce9
commit 7487995
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/modules/mod-pvp-mode/src/scripts/ProfessionNpc.cpp b/modules/mod-pvp-mode/src/scripts/ProfessionNpc.cpp
@@ -81,15 +81,14 @@ class Professions_NPC : public CreatureScript
                 bool LearnAllRecipesInProfession(Player *pPlayer, SkillType skill)
                 {
                         ChatHandler handler(pPlayer->GetSession());
-                        char* skill_name;
 
                         SkillLineEntry const *SkillInfo = sSkillLineStore.LookupEntry(skill);
-                        skill_name = SkillInfo->name[handler.GetSessionDbcLocale()];
+                        auto skill_name = SkillInfo->name[handler.GetSessionDbcLocale()];
 
                         if (!SkillInfo)
                         {
-                                sLog->outError("Profession NPC: received non-valid skill ID (LearnAllRecipesInProfession)");
-                                return false;
+                            sLog->outError("Profession NPC: received non-valid skill ID (LearnAllRecipesInProfession)");
+                            return false;
                         }
 
                         LearnSkillRecipesHelper(pPlayer, SkillInfo->id);