Skip to content

Commit

Permalink
improve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Rekard0 committed Jan 27, 2025
1 parent f6761b2 commit f5939dc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/contracts/src/MajorityVotingBase.sol
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ abstract contract MajorityVotingBase is
}

// For Standard and EarlyExecution modes, check if the support threshold
// has been reached early to determine success while still open.
// has been reached early to determine success while proposal is still open.
if (!isSupportThresholdReachedEarly(_proposalId)) {
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/test/10_unit-testing/11_plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2065,7 +2065,7 @@ describe('TokenVoting', function () {
expect(await plugin.isSupportThresholdReachedEarly(id)).to.be.true;
expect(await plugin.isMinParticipationReached(id)).to.be.true;
expect(await plugin.canExecute(id)).to.equal(false);
// It should return true as voting mode is Standard and proposal is still open, but we know that the proposal hasSucceeded.
// It should return true as voting mode is Standard and proposal is still open, but but thresholds are met.
expect(await plugin.hasSucceeded(id)).to.be.true;
});

Expand Down

0 comments on commit f5939dc

Please sign in to comment.