feat(Helm): Provide sensitive values as secret #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Any chance of getting feedback soon? 🙂 |
|
thanks for the PR, @DmitriyLewen - could you take a look at this? |
DmitriyLewen
approved these changes
Jan 12, 2023
|
@DmitriyLewen are you going to merge this soon? |
|
@simar7 i approved this PR. If you don't have any question - i think we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #479
A little bit of a lazy implementation but this way we could simply overwrite the whole content of the config file as a secret provided from another source (Hashicorp Vault + External Secrets Operator in our case)
Open for feedback of course but I am going to be on vacation for two weeks now.
Cheers!