-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: added kubernete secrets #199
Conversation
added kubernetes deployment file using secrets Issue aquasecurity#120
Codecov Report
@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 86.79% 87.24% +0.45%
==========================================
Files 28 28
Lines 1060 1098 +38
==========================================
+ Hits 920 958 +38
Misses 85 85
Partials 55 55
Continue to review full report at Codecov.
|
@krol3 |
To create the secret we dont need to update the yaml:
The username in the email could be different from the Service now, and in the other outputs samples. |
added instructions for creating and using secrets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By now, we try to keep simple with a quick installation from yaml. This effort to create configmaps and secrets will put in the helm chart. Please hold this PR to the helm charts.
closing in favour of #227 |
…uasecurity#199) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.4 to 1.7.5. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.4...v1.7.5) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
added kubernetes deployment file using secrets
Issue #120