Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added kubernete secrets #199

Closed
wants to merge 5 commits into from

Conversation

DmitriyLewen
Copy link
Collaborator

added kubernetes deployment file using secrets
Issue #120

added kubernetes deployment file using secrets
Issue aquasecurity#120
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #199 (9ed73da) into main (ab9d253) will increase coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   86.79%   87.24%   +0.45%     
==========================================
  Files          28       28              
  Lines        1060     1098      +38     
==========================================
+ Hits          920      958      +38     
  Misses         85       85              
  Partials       55       55              
Impacted Files Coverage Δ
routes/routes.go 100.00% <0.00%> (ø)
dbservice/dbparam.go 100.00% <0.00%> (ø)
msgservice/msghandling.go 87.35% <0.00%> (+0.93%) ⬆️
regoservice/regocheck.go 92.10% <0.00%> (+7.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d0356...9ed73da. Read the comment docs.

@AndreyLevchenko
Copy link
Contributor

@krol3
should we use it as default example?

@krol3
Copy link
Contributor

krol3 commented Nov 17, 2021

To create the secret we dont need to update the yaml:

kubectl create secret generic db-user-pass \
  --from-literal=username=devuser \
  --from-literal=password='xxxx'

The username in the email could be different from the Service now, and in the other outputs samples.

Copy link
Contributor

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By now, we try to keep simple with a quick installation from yaml. This effort to create configmaps and secrets will put in the helm chart. Please hold this PR to the helm charts.

@AndreyLevchenko
Copy link
Contributor

closing in favour of #227

kairi003 pushed a commit to kairi003/postee that referenced this pull request Oct 18, 2022
…uasecurity#199)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.4 to 1.7.5.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.4...v1.7.5)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants