Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send the Slack WebHook URL as a Secret #479

Open
lahiruperamune opened this issue Oct 20, 2022 · 5 comments
Open

Send the Slack WebHook URL as a Secret #479

lahiruperamune opened this issue Oct 20, 2022 · 5 comments

Comments

@lahiruperamune
Copy link

When setting up the action to send Slack notification, the Slack WebHook URL need to send as a plain text.
This URL should be sent as a secret value as it contains sensitive data.
Or else there should be a way to provide the whole config via a secret (/templates/cfg-configmap.yaml).

@grglzrv
Copy link
Contributor

grglzrv commented Oct 20, 2022

Hello @lahiruperamune, I planned to improve it. Anyway, good catch! @simar7 can I take care of it.

@tibuntu
Copy link
Contributor

tibuntu commented Nov 7, 2022

Hi! Any progress on this? I could potentially provide a PR for this within the next couple of days.

We'd love to use postee in our environment(s) but this blocks us from using it.

@grglzrv
Copy link
Contributor

grglzrv commented Nov 7, 2022

@tibuntu i am too busy, if you have opportunity create the PR

@tibuntu
Copy link
Contributor

tibuntu commented Dec 6, 2022

@grglzrv any chance there will be feedback on the related PR soon?

simar7 pushed a commit that referenced this issue Jan 19, 2023
@tibuntu
Copy link
Contributor

tibuntu commented Feb 21, 2023

@grglzrv or @simar7

Now that the related PR was merged, and also other improvements to the Helm-Chart were done, would you mind publishing a new version of the Helm-Chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants