This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
rgw/sfs: standardize log levels #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joao Eduardo Luis <[email protected]>
Signed-off-by: Joao Eduardo Luis <[email protected]>
Signed-off-by: Joao Eduardo Luis <[email protected]>
When building a preamble, clang-tidy really dislikes header recursion without '#pragma once'. Seems like it doesn't observe the header guards. Signed-off-by: Joao Eduardo Luis <[email protected]>
jecluis
added
kind/enhancement
Signed-off-by: Joao Eduardo Luis <[email protected]>
jecluis
force-pushed
the
wip-sfs-log-subsys
branch
from
2f1ac7a to
8dcd871
Compare
irq0
reviewed
Oct 31, 2023
Comment on lines
+55
to
+79
| #define lsfs_err(_dpp) lsfs_dout(_dpp, SFS_LOG_ERROR) | ||
| #define lsfs_err_for(_dpp, _whom) lsfs_dout_for(_dpp, SFS_LOG_ERROR, _whom) | ||
|
|
||
| #define lsfs_startup(_dpp) lsfs_dout(_dpp, SFS_LOG_STARTUP) | ||
| #define lsfs_startup_for(_dpp, _whom) \ | ||
| lsfs_dout_for(_dpp, SFS_LOG_STARTUP, _whom) | ||
|
|
||
| #define lsfs_shutdown(_dpp) lsfs_dout(_dpp, SFS_LOG_SHUTDOWN) | ||
| #define lsfs_shutdown_for(_dpp, _whom) \ | ||
| lsfs_dout_for(_dpp, SFS_LOG_SHUTDOWN, _whom) | ||
|
|
||
| #define lsfs_warn(_dpp) lsfs_dout(_dpp, SFS_LOG_WARN) | ||
| #define lsfs_warn_for(_dpp, _whom) lsfs_dout_for(_dpp, SFS_LOG_WARN, _whom) | ||
|
|
||
| #define lsfs_info(_dpp) lsfs_dout(_dpp, SFS_LOG_INFO) | ||
| #define lsfs_info_for(_dpp, _whom) lsfs_dout_for(_dpp, SFS_LOG_INFO, _whom) | ||
|
|
||
| #define lsfs_verb(_dpp) lsfs_dout(_dpp, SFS_LOG_VERBOSE) | ||
| #define lsfs_verb_for(_dpp, _whom) lsfs_dout_for(_dpp, SFS_LOG_VERBOSE, _whom) | ||
|
|
||
| #define lsfs_debug(_dpp) lsfs_dout(_dpp, SFS_LOG_DEBUG) | ||
| #define lsfs_debug_for(_dpp, _whom) lsfs_dout_for(_dpp, SFS_LOG_DEBUG, _whom) | ||
|
|
||
| #define lsfs_trace(_dpp) lsfs_dout(_dpp, SFS_LOG_TRACE) | ||
| #define lsfs_trace_for(_dpp, _whom) lsfs_dout_for(_dpp, SFS_LOG_TRACE, _whom) |
irq0
reviewed
Oct 31, 2023
| #define SFS_LOG_VERBOSE 10 | ||
| #define SFS_LOG_DEBUG 15 | ||
| #define SFS_LOG_TRACE 20 | ||
| #define SFS_LOG_MEGA_TRACE 30 |
There was a problem hiding this comment.
I like the name, but can't think of a use for something above trace.
|
I like it! |
jecluis
changed the title
irq0
approved these changes
Nov 3, 2023
I like it too much, and I'm sure someone will at some point use it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: aquarist-labs/s3gw#781
Signed-off-by: Joao Eduardo Luis <[email protected]>